Skip to content

Conversation

@brendanx67
Copy link
Member

Summary

Adds AutoQC build and test targets to Jamfile.jam to enable CI integration for batch tools (SkylineBatch + AutoQC).

Status

⏸️ DRAFT / ON HOLD - Waiting for TeamCity admin to return from vacation (several weeks).

All code changes are complete and ready for testing. TeamCity server configuration changes are deferred until admin returns.

What's Ready

  • ✅ AutoQC build targets added to Jamfile.jam (following SkylineBatch pattern)
  • ✅ Comprehensive TeamCity integration documentation in TODO
  • ✅ No impact on default Skyline build (targets marked explicit)

What's Needed (TeamCity Admin)

  1. Configure PANORAMAWEB_PASSWORD environment variable on build agents
  2. Add AutoQC build step: bjam AutoQC.exe
  3. Add 2 new test execution lines (see TODO for details)

Files Changed

  • pwiz_tools/Skyline/Jamfile.jam - Added AutoQC build/test targets
  • ai/todos/active/TODO-20251204_batch_tools_ci_integration.md - Comprehensive documentation

Documentation

All integration details, TeamCity execution scripts, and testing checklists are in the TODO file:
ai/todos/active/TODO-20251204_batch_tools_ci_integration.md

Next Steps

  • Wait for TeamCity admin to return
  • Test locally if desired: bjam AutoQC.exe and bjam AutoQCTest
  • Coordinate with admin for TeamCity configuration
  • Remove draft status and merge once CI integration is verified

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

brendanx67 and others added 6 commits December 4, 2025 08:11
Following SkylineBatch pattern:
- Added AssemblyInfo generation for AutoQC
- Added do_auto_qc rule/actions for building AutoQC.sln
- Added do_auto_qc_test rule/actions for running AutoQCTest.dll
- Added make targets AutoQC.exe and AutoQCTest with proper dependencies
- Tests run via vstest.console.exe like SkylineBatch
- Targets marked explicit - only build when specifically requested

Updated TODO with progress log documenting changes and revised scope.
Comprehensive documentation for when TeamCity admin returns:
- Build targets and bjam commands for AutoQC/SkylineBatch
- Proposed 3-line TeamCity execution script
- Environment variable configuration (PANORAMAWEB_PASSWORD)
- Testing checklist before enabling in TeamCity
- Known issues and future work
- Clear next steps for resuming work

Work is ON HOLD pending admin return from vacation.
PR #3697 created as draft: #3697
Work paused pending TeamCity admin return from vacation.
Fix TeamCity build warning about uncommitted files.

Root cause: generate-skyline-AssemblyInfo.cs runs whenever bjam
processes Jamfile (not just when target builds). This is intentional
to keep version info up-to-date.

Solution: Add AutoQC's AssemblyInfo.cs to .gitignore, following the
same pattern as SkylineBatch and other Skyline executables.

Updated TODO with explanation of AssemblyInfo generation behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant