Open
Conversation
damfinkel
force-pushed
the
feat/balance-v2
branch
from
87e20f4 to
553f042
Compare
src/components/alerts/index.tsx
Outdated
| const { t } = useTranslation(); | ||
|
|
||
| useAssetsToWithdraw(); | ||
| const { collectionId } = useParams(); |
Contributor
There was a problem hiding this comment.
Are we sure about this one ?
I think collectionId will be always undefined here, Because component is not under <Routes>...</Routes> in App.tsx
| const jellyCollection: JellyCollection = | ||
| await jellyInstance.getJellyCollection(collection); | ||
|
|
||
| const balanceResponse = await jellyCollection.getMyBalance(); |
Contributor
There was a problem hiding this comment.
I guess we can rename getMyBalance method to getAssetsToWithdraw. Because getMyBalance is something reminds me of plugBalance at 1st glance.
Yeah just think about this. And feel free to proceed if you are ok. Thanks
Contributor
Author
There was a problem hiding this comment.
Ok, I like that suggestion. I'll change it in JellyJS and come back to this PR
damfinkel
force-pushed
the
feat/balance-v2
branch
from
553f042 to
f0ff6fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Migration of the balanceOf method used to see if there's assets to withdraw migrated to v2.
How?
Contribution checklist?
Demo?
There was a console error saying that balanceOf was not an existing method for the canister. The error is gone now.