AB#3125: Add support for unifiBTC and unifiUSD#52
Merged
Conversation
JasminMusic
reviewed
Jan 19, 2025
| @@ -37,7 +54,8 @@ export class NucleusAccountantHandler { | |||
| * @returns The viem contract. | |||
| */ | |||
| public getContract() { | |||
There was a problem hiding this comment.
Is there a possibility for runtime error in case NUCLEUS_CONTRACT_ADDRESSES doesn't exist?
Collaborator
Author
There was a problem hiding this comment.
Yes, if the contract doesn't exist for the selected chain. We can put checks in place and throw more sophisticated errors for all the handlers but that for now can be shelved I think as it's working fine at the moment.
JasminMusic
approved these changes
Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updated the nucleus contracts to be able to work with any UniFi token.
Which issue(s) does this PR fixes:
Fixes AB#3125