Add I301 check, for TYPE_CHECKING too far from previous import#217
Open
dgw wants to merge 1 commit intoPyCQA:mainfrom
Open
Add I301 check, for TYPE_CHECKING too far from previous import#217dgw wants to merge 1 commit intoPyCQA:mainfrom
dgw wants to merge 1 commit intoPyCQA:mainfrom
Conversation
sigmavirus24
force-pushed
the
error/new/I301
branch
from
319852e to
2abab2a
Compare
sigmavirus24
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to suggested new check in #214 (comment). Thanks to the testing framework already in place, I'm reasonably confident that this has no unintended side-effects. 😁
The new code
I301covers both "too many newlines" and "non-import stuff between the other imports and TYPE_CHECKING" cases. (This way was cleaner than trying to keep track of theprevious_non_importnode, which would complicate the iterator.)