ci: move ffi-check docs build inside its build script#5622
Draft
davidhewitt wants to merge 4 commits intoPyO3:mainfrom
Draft
ci: move ffi-check docs build inside its build script#5622davidhewitt wants to merge 4 commits intoPyO3:mainfrom
ffi-check docs build inside its build script#5622davidhewitt wants to merge 4 commits intoPyO3:mainfrom
Conversation
Icxolu
reviewed
Nov 12, 2025
Contributor
There was a problem hiding this comment.
I generally dislike to check-in the cargo config file. At least to some degree it contains options that are specific to the build machine which I might want to adjust locally just for myself.
Member
Author
There was a problem hiding this comment.
Fair concern. I'm beginning to think that the "right" solution is to fix the link issues rather than find new hacks to suspend it.
Member
Author
|
With #5624 merged this particular PR is no longer needed, but I would like to return to this and merge the change to move docs build inside the build script. I'll leave as draft for now. |
davidhewitt
changed the title
ffi-check dependency on extension-module featureffi-check docs build inside its build script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To unblock #5588
I made two changes:
PYO3_BUILD_EXTENSION_MODULEenv var to controlpyo3-ffi-checklinking (instead of the feature)pyo3-ffi-checkbuild script, makes it work a bit better.With this, the
pyo3-ffi-checkfunctionality is better encapsulated within itself rather than in thenoxfile.