sync pystate.h headers with Python 3.14#5711
Conversation
|
🎉 looks like CI is finally green here. |
|
I'll try to take a look today. I'm doing other pyo3-ffi stuff right now so all this is fresh for me. |
pyo3-ffi/src/cpython/pystate.rs
Outdated
| pub(crate) fn _PyThreadState_UncheckedGet() -> *mut PyThreadState; | ||
|
|
||
| // skipped PyThreadState_EnterTracing | ||
| // skipped PyThreadState_LeaveTracing |
There was a problem hiding this comment.
why skip these? someone writing a profiler might want this.
| // skipped private _PyThread_CurrentFrames | ||
|
|
||
| // skipped PyUnstable_ThreadState_SetStackProtection | ||
| // skipped PyUnstable_ThreadState_ResetStackProtection |
There was a problem hiding this comment.
Same here - seems reasonable to expose these to me.
There was a problem hiding this comment.
For this one I am going to skip for now, just because "unstable" APIs seem to imply they're more likely to have churn so I'm tempted to wait to take on the maintenance burden until someone asks to use these.
|
Thanks! I guess for the 3.15 changes I can never quite decide when the appropriate "sync" point is. My instinct is that before 3.15.0 we can make changes to the headers to begin accomodating the upcoming version and otherwise the 3.14 headers are the best reference point. |
2 participants
Part of #5592
Synchronize the
pystatedeclarations with Python 3.14