Make parallel iteration test less sensitive to timing#5759
Merged
bschoenmaeckers merged 1 commit intoPyO3:mainfrom Jan 28, 2026
Merged
Make parallel iteration test less sensitive to timing#5759bschoenmaeckers merged 1 commit intoPyO3:mainfrom
bschoenmaeckers merged 1 commit intoPyO3:mainfrom
Conversation
ee2be7c to
a77d24c
Compare
Merging this PR will degrade performance by 13.62%
Performance Changes
Comparing |
Tpt
approved these changes
Jan 28, 2026
bschoenmaeckers
approved these changes
Jan 28, 2026
Member
|
Thanks for debugging, this makes sense to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5752 (I think)
I haven't been able to reproduce the failure on my Macbook. I suspect that this is a timing issue though, so I rewrote the test to improve synchronization between the worker threads and also make it so both threads exit the loop as soon as the borrow error happens.