Skip to content

Make parallel iteration test less sensitive to timing#5759

Merged
bschoenmaeckers merged 1 commit intoPyO3:mainfrom
ngoldbaum:fix-parallel-iter-test
Jan 28, 2026
Merged

Make parallel iteration test less sensitive to timing#5759
bschoenmaeckers merged 1 commit intoPyO3:mainfrom
ngoldbaum:fix-parallel-iter-test

Conversation

@ngoldbaum
Copy link
Contributor

Fixes #5752 (I think)

I haven't been able to reproduce the failure on my Macbook. I suspect that this is a timing issue though, so I rewrote the test to improve synchronization between the worker threads and also make it so both threads exit the loop as soon as the borrow error happens.

@ngoldbaum ngoldbaum force-pushed the fix-parallel-iter-test branch from ee2be7c to a77d24c Compare January 28, 2026 15:36
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

Merging this PR will degrade performance by 13.62%

❌ 1 regressed benchmark
✅ 99 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
format_simple 185 ns 214.2 ns -13.62%

Comparing ngoldbaum:fix-parallel-iter-test (a77d24c) with main (8f0af50)

Open in CodSpeed

@bschoenmaeckers bschoenmaeckers added this pull request to the merge queue Jan 28, 2026
Merged via the queue into PyO3:main with commit 80ba87b Jan 28, 2026
91 of 92 checks passed
@davidhewitt
Copy link
Member

Thanks for debugging, this makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failure in main CI for 3.15t, macos

4 participants