Skip to content

DEA cost for Fischer-Tropsch, methanolisation#238

Open
millingermarkus wants to merge 18 commits intoPyPSA:masterfrom
millingermarkus:revert_DEA_cost
Open

DEA cost for Fischer-Tropsch, methanolisation#238
millingermarkus wants to merge 18 commits intoPyPSA:masterfrom
millingermarkus:revert_DEA_cost

Conversation

@millingermarkus
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

Changing from Agora values for methanolisation, Fischer-Tropsch and methanation to DEA values.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. There are a few things I have to ask you to recheck!

@euronion euronion linked an issue Sep 17, 2025 that may be closed by this pull request
@millingermarkus
Copy link
Contributor Author

@euronion I made the updates, please have a look!

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one or two things to double-check (and re-run csv creation).

millingermarkus and others added 3 commits November 3, 2025 14:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major unwanted changes here (additional empty columns added). Please clean up.
Also please make sure that GH can render it, currently the format is corrupt.

@@ -1,622 +1,603 @@
technology,parameter,year,value,unit,currency_year,source,further_description
methanation,investment,2020,748,EUR/kW_CH4,2017,"Agora Energiewende (2018): The Future Cost of Electricity-Based Synthetic Fuels (https://www.agora-energiewende.de/en/publications/the-future-cost-of-electricity-based-synthetic-fuels-1/), table 6: “Reference scenario”.",
methanation,lifetime,2020,20,years,2017,Guesstimate.,"Based on lifetime for methanolisation, Fischer-Tropsch plants."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the source here? If we change the source / data for methanolisation, we either need to keep the original reference here or also change the assumption. But leaving "Guesstimate" hanging alone is not traceable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional, seems my editor has been spinning, sorry! Will correct and double check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, been there myself before, that's why we review. :)

electrolysis,efficiency,0.5773,per unit,"Danish Energy Agency, inputs/data_sheets_for_renewable_fuels.xlsx",86 AEC 100 MW: Hydrogen Output,2020.0
electrolysis,efficiency-heat,0.2762,per unit,"Danish Energy Agency, inputs/data_sheets_for_renewable_fuels.xlsx",86 AEC 100 MW: - hereof recoverable for district heating,2020.0
electrolysis,investment,2000.0,EUR/kW_e,private communications; IEA https://iea.blob.core.windows.net/assets/9e0c82d4-06d2-496b-9542-f184ba803645/TheRoleofE-fuelsinDecarbonisingTransport.pdf,,2020.0
electrolysis,investment,2000.0,EUR/kW_e,private communications, IEA https://iea.blob.core.windows.net/assets/9e0c82d4-06d2-496b-9542-f184ba803645/TheRoleofE-fuelsinDecarbonisingTransport.pdf,2020.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended change, please revert

gas storage charger,investment,15.2479,EUR/kW,"Danish Energy Agency, inputs/technology_data_catalogue_for_energy_storage.xlsx",,2020.0
gas storage discharger,investment,5.0826,EUR/kW,"Danish Energy Agency, inputs/technology_data_catalogue_for_energy_storage.xlsx",,2020.0
geothermal,CO2 intensity,0.12,tCO2/MWh_th,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551",Likely to be improved; Average of 85 percent of global egs power plant capacity; Result of fluid circulation through rock formations,2020.0
geothermal,CO2 intensity,0.12,tCO2/MWh_th,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551",Likely to be improved,2020.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended change, please revert. And check for more unintended changes

@euronion
Copy link
Collaborator

Only some polishing left

@millingermarkus
Copy link
Contributor Author

Now it should be good to go! Sorry for the unintended changes. Thanks @euronion and @fneum for the thorough check!

Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to DEA for Fischer-Tropsch and Methanol

3 participants