Open
Conversation
euronion
requested changes
Jan 9, 2026
Collaborator
euronion
left a comment
There was a problem hiding this comment.
Thanks!
- Why not include the other inputs (electricity) in the calculation?
- DEA also has FTF, I don't remember why we didn't take them before (maybe they weren't there). Maybe an alternative?
- Have you checked whether the cross interaction with the electrobiofuels is correct? (see the entries that change as a byproduct of your change).
- Please add release notes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fischer-Tropsch efficiency is currently too high. Checking the old source (section 6.3.2.2) points to Fasihi et. al which is not naming the efficiency as stated in the report
To not break code - instead of just deleting the
Fischer-Tropsch efficiencyI propose to overwrite it with the inverse of the hydrogen input (at least that is what it's used for in e.g. PyPSA-Eur)Checklist
doc.not applicable
environment.yaml(if applicable).not applicable
doc/release_notes.rstof the upcoming release is included.not applicable