Implement Sortino ratio for portfolio#459
Open
dpapakyriak wants to merge 1 commit intoPyPortfolio:mainfrom
Open
Implement Sortino ratio for portfolio#459dpapakyriak wants to merge 1 commit intoPyPortfolio:mainfrom
dpapakyriak wants to merge 1 commit intoPyPortfolio:mainfrom
Conversation
Collaborator
|
I'm not merging this for now for a couple of reasons:
|
|
Is there any update related to this topic? |
Contributor
|
@fkiraly please close. For that purpose there are packages such as quantstats or jquantstats. Minimizing the semi variance is a different beast which is not solved here. This can be done though with cvxpy. |
Collaborator
|
@tschm, can you provide your reasoning why this feature does not beling in It seems topical to me. Maybe there is a wider scope discussion to be had. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented an initial attempt for the sorting ratio, as asked in issue #401. In order to achieve this, I initially implemented a function to calculate the downside deviation for all assets. Then, I made the sorting_ratio() function to return the sorting ratio for a given portfolio. This is a draft, please review and contact me via email to fix any issues and/or any additional documentation.