Make parent formid a part of autogenerated oid#520
Conversation
ezag
force-pushed
the
include-oid-into-formid
branch
from
6863f9d to
f364816
Compare
ezag
changed the title
|
@ezag lint is failing. Would you please run I'll do a detailed review once GitHub Actions passes. |
|
@ezag additionally the functional tests must pass. Please let me know if you need assistance with that part. It can be tricky because deformdemo is in a separate repository. |
|
@stevepiercy thanks, looks like there's plenty of instructions on setting up & running the functional tests - I'm going to get to it in a while |
ezag
force-pushed
the
include-oid-into-formid
branch
from
f364816 to
3cc3908
Compare
|
Would you also please run black over the code base with |
ezag
force-pushed
the
include-oid-into-formid
branch
from
3cc3908 to
f0e16dd
Compare
ezag
force-pushed
the
include-oid-into-formid
branch
from
f0e16dd to
065df8c
Compare
|
@stevepiercy added meaningful test name and applied tox format; also updated related functional test Pylons/deformdemo#120 |
|
@ezag it looks like GitHub Actions deprecated pypy3 on macos-latest. Would you please rebase your branch on |
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
I have a couple of questions, now that I took a little more time to look at this. Would you please respond to them? Thank you!
| # Use kwargs to pass flags to descendant fields; saves cluttering | ||
| # the constructor | ||
| kw["focus"] = self.focus | ||
| self.formid = formid |
There was a problem hiding this comment.
Is there a reason you moved this line? I don't understand why it was moved.
There was a problem hiding this comment.
The formid should be set prior to children initialization, since Field.__init__ does rely on it.
ezag
force-pushed
the
include-oid-into-formid
branch
from
592e72f to
c896125
Compare
|
@stevepiercy rebased on up-to-date main |
2 participants
Better late then never :) #394