Pass the Request.decode errors argument down to transcode_query#438
Open
jeremylowery wants to merge 1 commit intoPylons:mainfrom
Open
Pass the Request.decode errors argument down to transcode_query#438jeremylowery wants to merge 1 commit intoPylons:mainfrom
jeremylowery wants to merge 1 commit intoPylons:mainfrom
Conversation
…he form and query parsing call to control form decoding
mmerickel
requested changes
Oct 25, 2022
Member
mmerickel
left a comment
mmerickel
left a comment
There was a problem hiding this comment.
This seems to make sense. Would love to see a test that passes in the ignore value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when calling Request.decode("encoding", "ignore"), webob still raises a decode error with invalid characters despite passing an "ignore" argument to errors. This fix uses the given argument.