refactor: tidy uses of read_node_def in visualizer
#320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acl-cqc
commented
Feb 10, 2026
acl-cqc
commented
- Avoid repeated and unnecessary calls
- Note that some of these (esp. loop/map) are only to obtain the outputs
- Also update doc viz -> vis
acl-cqc
commented
Feb 10, 2026
|
|
||
| ``` | ||
| tkr viz | ||
| tkr vis |
Contributor
Author
There was a problem hiding this comment.
I am not sure about uv run tkr_viz_graph further down e.g. whether that should be uv run tkr_vis_graph - neither work for me yet
acl-cqc
commented
Feb 10, 2026
|
|
||
| if definition is not None: | ||
| if has_error: | ||
| if storage.is_node_started(node_location): |
Contributor
Author
There was a problem hiding this comment.
this appears the correct function in storage, rather than reading the node_def. (Yes, it has the same effect...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.