Skip to content

Update formatting to the Runic style#215

Merged
Jutho merged 7 commits intoQuantumKitHub:masterfrom
VictorVanthilt:vv-runic
Jul 28, 2025
Merged

Update formatting to the Runic style#215
Jutho merged 7 commits intoQuantumKitHub:masterfrom
VictorVanthilt:vv-runic

Conversation

@VictorVanthilt
Copy link
Member

Change the formatting to the one defined in QuantumKitHubActions, namely the Runic formatter.

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 73.45455% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.01%. Comparing base (455a69f) to head (0966002).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
ext/TensorOperationscuTENSORExt.jl 3.44% 28 Missing ⚠️
src/indexnotation/poly.jl 45.94% 20 Missing ⚠️
src/precompile.jl 15.38% 11 Missing ⚠️
src/implementation/functions.jl 84.61% 4 Missing ⚠️
ext/TensorOperationsChainRulesCoreExt.jl 82.35% 3 Missing ⚠️
src/indexnotation/tensormacros.jl 25.00% 3 Missing ⚠️
src/indexnotation/instantiators.jl 88.88% 2 Missing ⚠️
src/indexnotation/preprocessors.jl 87.50% 1 Missing ⚠️
src/interface.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   83.06%   82.01%   -1.06%     
==========================================
  Files          25       30       +5     
  Lines        2150     2558     +408     
==========================================
+ Hits         1786     2098     +312     
- Misses        364      460      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Member

lkdvos commented Jul 25, 2025

I would like to go through and fix up some of the formatting where there are just too many new lines because of the changes.

@VictorVanthilt
Copy link
Member Author

added you to my fork @lkdvos

@lkdvos lkdvos requested a review from Jutho July 27, 2025 16:34
@Jutho
Copy link
Member

Jutho commented Jul 28, 2025

I think this mostly looks good and often better than the original. Some of the linebreaks could use some further tweaking, but that is probably something that we can do in later PRs as we make further changes to the codebase.

@Jutho Jutho merged commit 6fa0c01 into QuantumKitHub:master Jul 28, 2025
14 of 16 checks passed
@VictorVanthilt VictorVanthilt deleted the vv-runic branch July 28, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants