Skip to content

Add more descriptive errors to ncon#216

Merged
Jutho merged 2 commits intoQuantumKitHub:masterfrom
VictorVanthilt:vv-descriptive-ncon
Jul 28, 2025
Merged

Add more descriptive errors to ncon#216
Jutho merged 2 commits intoQuantumKitHub:masterfrom
VictorVanthilt:vv-descriptive-ncon

Conversation

@VictorVanthilt
Copy link
Member

The invalid NCON network error did not provide the user with information on why the network did not comply with the ncon style, while this information was available during the checking procedure.

This PR provides the user more information on why their network did not conform to the ncon style.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.05%. Comparing base (455a69f) to head (b1009fd).
⚠️ Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
src/indexnotation/ncontree.jl 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   83.06%   82.05%   -1.02%     
==========================================
  Files          25       30       +5     
  Lines        2150     2564     +414     
==========================================
+ Hits         1786     2104     +318     
- Misses        364      460      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Member

Jutho commented Jul 28, 2025

Looks good to me; I'll merge and include it in the 5.3 release.

@Jutho Jutho merged commit 8144420 into QuantumKitHub:master Jul 28, 2025
15 of 16 checks passed
@VictorVanthilt VictorVanthilt deleted the vv-descriptive-ncon branch July 28, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants