Skip to content

change info message to only appear during precompilation#217

Merged
Jutho merged 1 commit intomasterfrom
jh/changeprecompileinfo
Jul 28, 2025
Merged

change info message to only appear during precompilation#217
Jutho merged 1 commit intomasterfrom
jh/changeprecompileinfo

Conversation

@Jutho
Copy link
Member

@Jutho Jutho commented Jul 28, 2025

No description provided.

@Jutho Jutho requested a review from lkdvos July 28, 2025 09:58
@lkdvos
Copy link
Member

lkdvos commented Jul 28, 2025

Did you check if this does what we want? I don't really recall, but I remember having some issues making sure this actually prints to the repl

@Jutho
Copy link
Member Author

Jutho commented Jul 28, 2025

Yes this prints to the repl, at least when doing "using TensorOperations" after it got updated and needs to be recompiled (possibly not if "using SomeHigherLevelPackageThatDependsOnTensorOperations"). I first tried to add a print statement to "deps/build.jl", but that just gets printed to a "build.log" file and an info message is printed to the REPL to say that there is some extra info in the "build.log" file.

@Jutho
Copy link
Member Author

Jutho commented Jul 28, 2025

Ok I can now confirm that the info message is also shown when TensorOperations is compiled as a consequence of being loaded in implicitly by a higher level package, so I will merge and tag.

@Jutho Jutho merged commit 04c8428 into master Jul 28, 2025
14 checks passed
@Jutho Jutho deleted the jh/changeprecompileinfo branch July 28, 2025 11:58
@lkdvos
Copy link
Member

lkdvos commented Jul 28, 2025

The build step was also the first thing I tried, great minds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants