You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is nice that you minimized the size of the png files, but please could you give a little bit of detail about how you edited them? What program / workflow did you use to achieve this? I see that in some images the color palette has been changed, presumably to reduce the amount of data stored per pixel. This can potentially cause some problems with the way Java loads images. This is not the case right now with your changes and MCA Selector using a JavaFX Image to load them, but it might cause inconsistencies in behaviors in the future if this should change (especially when using BufferedImage instead).
The point of the test images from the unit tests is that they are compared to images generated by MCA Selector. So those images should not be modified either.
Sorry for no details, I write them if someone asks as I'm doing many prs like this recently.
I used https://github.com/shssoichiro/oxipng for this, all compression was lossless, I'm not sure about any changes in the color palette - the number of colors is obviously the same, and here is a part of a log from my previous pr
The command to achieve the same results is oxipng -o max -s full -r --fix. An slightly worse alternative to this is to use this Github bot.
The GitHub Logo cannot be modified
Ok, I can replace it with the original if this pr still seems helpful in any way.
The point of the test images from the unit tests is that they are compared to images generated by MCA Selector. So those images should not be modified either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lossless compression.