Open
Conversation
Owner
|
Hi @thuanhuynhh Thank you for your contribution and for working on updates for OJS 3.5.0. I noticed that this pull request has over 1800 loc marked as changed, which makes reviewing the real changes very challenging. It seems like the large number of changes might be due to unintended modifications, such as:
To ensure the review process goes smoothly, could you please verify and isolate the actual intended changes? Here are some possible steps:
This will help us focus only on the key changes needed for the update and greatly ease the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for OJS 3.5.0