Skip to content

Jun/smoothquant update yadai rebase v2 0204#1976

Open
yadaish wants to merge 3 commits intomainfrom
jun/smoothquant_update_yadai_rebase_v2_0204
Open

Jun/smoothquant update yadai rebase v2 0204#1976
yadaish wants to merge 3 commits intomainfrom
jun/smoothquant_update_yadai_rebase_v2_0204

Conversation

@yadaish
Copy link
Contributor

@yadaish yadaish commented Feb 5, 2026

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@yadaish yadaish requested a review from a team February 5, 2026 02:21

sorted_ids = sorted_token_ids.contiguous()
sorted_eids = sorted_expert_ids.contiguous()
sorted_size = int(sorted_ids.numel())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F841> reported by reviewdog 🐶
Local variable sorted_size is assigned to but never used

Suggested change
sorted_size = int(sorted_ids.numel())
int(sorted_ids.numel())


sorted_ids = sorted_token_ids.contiguous()
sorted_eids = sorted_expert_ids.contiguous()
sorted_size = int(sorted_ids.numel())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F841> reported by reviewdog 🐶
Local variable sorted_size is assigned to but never used

Suggested change
sorted_size = int(sorted_ids.numel())
int(sorted_ids.numel())

import aiter
from aiter import dtypes
from aiter.test_common import checkAllclose, benchmark, run_perftest
from aiter.int4_utils import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F403> reported by reviewdog 🐶
from aiter.int4_utils import * used; unable to detect undefined names

w1_scale_aiter = w1_scale
w2_scale_aiter = w2_scale
if WQDType == torch.int4: # int4 w quant
w1_qt_aiter = rearrange_4bit_elements(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F405> reported by reviewdog 🐶
rearrange_4bit_elements may be undefined, or defined from star imports

w2_scale_aiter = w2_scale
if WQDType == torch.int4: # int4 w quant
w1_qt_aiter = rearrange_4bit_elements(
convert_int8_to_uint32_int4(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F405> reported by reviewdog 🐶
convert_int8_to_uint32_int4 may be undefined, or defined from star imports

shuffle_weight(w1_qt_aiter, (16, 16), use_int4=True)
)
)
w2_qt_aiter = rearrange_4bit_elements(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F405> reported by reviewdog 🐶
rearrange_4bit_elements may be undefined, or defined from star imports

)
)
w2_qt_aiter = rearrange_4bit_elements(
convert_int8_to_uint32_int4(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F405> reported by reviewdog 🐶
convert_int8_to_uint32_int4 may be undefined, or defined from star imports

sorted_ids = sorted_ids.contiguous()
sorted_w = sorted_w.contiguous()
sorted_eids = sorted_eids.contiguous()
sorted_size = int(sorted_ids.numel())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F841> reported by reviewdog 🐶
Local variable sorted_size is assigned to but never used

Suggested change
sorted_size = int(sorted_ids.numel())
int(sorted_ids.numel())

from aiter.fused_moe_bf16_asm import asm_moe
from aiter.ops.shuffle import shuffle_weight
from aiter import pertoken_quant
from aiter.int4_utils import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F403> reported by reviewdog 🐶
from aiter.int4_utils import * used; unable to detect undefined names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant