Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add compile-time configuration for FP32 to BF16 rounding mode in RMSNorm CK kernel.
This PR allows users to control the FP32 to BF16 conversion behavior in CK RMSNorm kernel via the
CK_TILE_FLOAT_TO_BFLOAT16_DEFAULTenvironment variable.Changes
-DCK_TILE_FLOAT_TO_BFLOAT16_DEFAULTcompile flag tomodule_rmsnorminoptCompilerConfig.json2(Truncate mode, same as CK default)Rounding Mode Options
Usage
To use RNE (Round to Nearest Even) rounding mode:
Motivation
Different rounding modes may affect numerical precision in model inference. RNE is the IEEE 754 default and provides better numerical stability for precision-sensitive workloads.