Conversation
|
@dbjorge I'm not the maintainer, but I was looking at this patch, and when I run Any ideas? Could it be to do with a newer node version? |
Maybe; I can't say without knowing what version you're trying to run against. The version I tested against is Node 18 (because it is the earliest version this library's package.json |
|
@RSeidelsohn , do you anticipate being able to review this? If not I'll go ahead and close it to clean up my list of outstanding work. |
|
Hello @dbjorge , thanks a lot for your valuable contribution! Please give me more time to tackle this. I came back to actually maintaining the code base after months of inactivity and am currently in the middle of a bigger refactoring. After that, I'll look into your PR and will do my best checking it and resolving probably merge conflicts. Will send a ping when done! |
While I was looking at making a different contribution, I noticed that the repo's tests weren't in a running state. It looks like the tests were written prior to the project converting to
"type": "module", but the tests were never updated to work with that. This PR:jenkins-mochaandnycwithmochaandc8to re-enable debugging and code coveragepackages-test.jswas usingchild_process.spawnto fix how it was trying to read stdouttest.tscases that pin to the actual dependencies of the repo to account for the dependency updates