fix/disable-switching-if-the-same-params-used#79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the tenant database switching logic to ensure that a switch only occurs when the full set of connection parameters changes, rather than just the database name. This prevents unnecessary reconnections when the configuration is unchanged and correctly handles cases where the same database name is used on different hosts. The changes also include an additional unit test to verify the new behavior.
Improvements to tenant database switching logic:
DbSwitchEventListenerto track the full set of connection parameters ($currentTenantParams) instead of only the database name, ensuring more accurate detection of when a switch is needed.onHakamMultiTenancyBundleEventSwitchDbEventto skip switching only if all connection parameters match, not just the database name. [1] [2]Testing enhancements:
testSwitchesWhenSameDbNameButDifferentHostto verify that a switch occurs when the database name is the same but other parameters (like host) differ, ensuring correct behavior in multi-host scenarios.