Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
DbSwitchEventListenerto improve its design, simplify dependency injection, and enhance testing. The most important changes include replacing the use ofContainerInterfacewithManagerRegistry, updating event handling logic, and modernizing the class implementation and its tests.Refactoring and Dependency Injection:
ContainerInterfacewithManagerRegistryinDbSwitchEventListener, allowing direct access to Doctrine connections and improving type safety and clarity. (src/EventListener/DbSwitchEventListener.php)ManagerRegistrydirectly, removing unnecessary container access. (src/EventListener/DbSwitchEventListener.php,tests/Unit/EventListener/DbSwitchEventListenerTest.php) [1] [2]Event Handling Improvements:
onHakamMultiTenancyBundleEventSwitchDbEventtoonSwitchDband updated the event subscription mapping for clarity and consistency. (src/EventListener/DbSwitchEventListener.php,tests/Unit/EventListener/DbSwitchEventListenerTest.php) [1] [2]src/EventListener/DbSwitchEventListener.php)Testing Updates:
ManagerRegistrymocks instead of container mocks, simplifying test setup and expectations. (tests/Unit/EventListener/DbSwitchEventListenerTest.php) [1] [2] [3] [4] [5]tests/Unit/EventListener/DbSwitchEventListenerTest.php) [1] [2] [3] [4]Code Modernization:
DbSwitchEventListenerto afinalclass and implementedResetInterfacefor better lifecycle management and compatibility with Symfony's service reset mechanism. (src/EventListener/DbSwitchEventListener.php)src/EventListener/DbSwitchEventListener.php)