Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
TenantTestTraitto simplify and standardize tenant switching logic in tests, and refactors existing integration tests to use this trait instead of directly dispatching events. Additionally, a dedicated test suite is added to ensure the trait's correctness and robustness. These changes improve test maintainability, reduce boilerplate, and ensure consistent tenant state management across tests.New test utility trait:
TenantTestTraitinsrc/Test/TenantTestTrait.php, providing reusable methods for switching tenants, resetting tenant-related state, and running code within a specific tenant context in tests. This trait encapsulates event dispatching and cleanup logic for tenant switching.Refactoring of integration tests to use the trait:
TenantConnectionSwitchingTestandTenantConnectionConfigDTOFlowTestto useTenantTestTraitfor tenant switching and state management, replacing manual event dispatching with trait methods such asswitchToTenantandresetTenantState. [1] [2] [3] [4] [5] [6] [7] [8] [9]New tests for trait behavior:
TenantTestTraitTestto comprehensively test the behavior ofTenantTestTrait, including correct state reset after execution, exception safety, manual and automatic reset scenarios, sequential calls, and idempotency of reset operations.