Fix typo with prediction of means from sampling#5
Open
henry-berger wants to merge 1 commit intoRansML:masterfrom
Open
Fix typo with prediction of means from sampling#5henry-berger wants to merge 1 commit intoRansML:masterfrom
henry-berger wants to merge 1 commit intoRansML:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BHM Pytorch classes appear to have a typo in
predictSampling. Instead of returning the mean and standard deviation of the samples, the current code returns two copies of the standard deviation.This PR fixes that, by computing the mean and standard deviation. This is consistent with the way the mean and standard deviation are computed in
BHM_tutorial.ipynb.