Update NYC, update require-dir, more specific import arg#118
Open
MarchosiasM wants to merge 1 commit intoRanvierMUD:masterfrom
Open
Update NYC, update require-dir, more specific import arg#118MarchosiasM wants to merge 1 commit intoRanvierMUD:masterfrom
MarchosiasM wants to merge 1 commit intoRanvierMUD:masterfrom
Conversation
MarchosiasM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports were failing in
node v12.16.3as were the tests in this repository.Updating NYC fixed the tests and being more specific with the
require-dirrequire plugin addressed the imports.Seems like the more specific imports were necessary since
require.extensionsseems to be deprecated in later versions of Nodejshttps://nodejs.org/api/modules.html#modules_require_extensions