Fix OpenVINO inference engine integration issues from PR #38#50
Draft
Fix OpenVINO inference engine integration issues from PR #38#50
Conversation
…on, fix have_key method, fix YAML indentation Co-authored-by: SWHL <28639377+SWHL@users.noreply.github.com>
…tation Co-authored-by: SWHL <28639377+SWHL@users.noreply.github.com>
Co-authored-by: SWHL <28639377+SWHL@users.noreply.github.com>
Co-authored-by: SWHL <28639377+SWHL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review pull request for changes in RapidLayout
Fix OpenVINO inference engine integration issues from PR #38
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #38 added OpenVINO inference support but had critical bugs preventing functionality and several safety issues.
Critical Fixes
Config path bug:
_init_config()read fromcfg.get("engine_cfg", {})instead ofcfgdirectly, causing all YAML settings to be ignored:Missing import:
os.cpu_count()used without importingos, causing immediateNameError.None injection:
_set()with lambda cast could addNonevalues to OpenVINO config dict:Safety Improvements
os.cpu_count()returningNonebefore min() comparisonhave_key()now checks "framework" level consistently withget_character_list()except.value.splitlines().get()pattern throughout to prevent KeyErrorStyle Fixes
onnxruntimeblock_set()calls except where lambda spans multiple lines__init__.py✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.