Add guild and user context to autocomplete logs#10394
Add guild and user context to autocomplete logs#10394vmphase wants to merge 1 commit intoRapptz:masterfrom
Conversation
|
Please read the comment that you deleted. It's explicit that there is no exception or call to do this because this exception would be impossible to handle. If an exception's only purpose is to be logged and not handled then you might as well just log the exception (which is what the library does). While it's true that an error handler attached to a command should also be checking the exceptions it has received before actually being called, this implementation just calls I'd reconsider this PR if you just modified the logging call to have more information that was needed to address the original complaint. I just don't think this type of exception is good because it's not possible to handle outside of logging. |
aed37dd to
3fbf728
Compare
|
Thanks for the feedback. I've updated the PR, adding |
Summary
This PR improves visibility when autocomplete fails or times out (e.g.,
10062: Unknown interaction) by adding missing context to the logs, as discussed here.Checklist