keyword filtering on articles' titles#1183
Open
V4ldum wants to merge 3 commits intoReadYouApp:mainfrom
Open
Conversation
Author
|
@JunkFood02 Hi, did you find a bit of time to check the code ? I've been running this version on my device and I didn't see any obvious issues with the filter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160
Closes #195
Closes #337
Closes #1112
Please DO review the code throroughly, I basically don't know anything about Kotlin and this PR was done by copy & paste and a bit an AI for things I didn't know how to do. I am very confident I messed up or forgot some things. The feature works but I'm pretty sure it can be improved. I also implemented the filtering for Google and Fever completely blind because I don't know how to use those RSS feeds.
Moreover, I found a small bug when moving a feed to a new group by creating it. If you create a group then create a new one, the text field of the pop-up dialog is prefilled with the first value eventhough it's supposed to be cleared by the viewmodel. This obviously also happens when adding a new keyword filter because I copied the code from groups. No idea how to fix this.
I'll be running an APK built from this branch on my personal device while this gets merged so I can catch any bugs I might have in my code.