fix: Handle invalid dates (e.g., Jalali calendar) by adding validation and fallback to updated date#1228
Open
Meshkati wants to merge 1 commit intoReadYouApp:mainfrom
Open
fix: Handle invalid dates (e.g., Jalali calendar) by adding validation and fallback to updated date#1228Meshkati wants to merge 1 commit intoReadYouApp:mainfrom
Meshkati wants to merge 1 commit intoReadYouApp:mainfrom
Conversation
…d date - Add isTooOld() validation to reject dates before 1970 - Fall back to updatedDate when publishedDate fails validation - Fixes incorrect display of Jalali calendar dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updatedDatewhenpublishedDateis invalidProblem
Some RSS/Atom feeds use Jalali (Persian) calendar dates with Persian numerals in the
<published>tag:The Rome library converts Persian numerals (۰-۹) to ASCII (0-9) and parses 1404-11-07 as a valid Gregorian date. This results in articles displaying as "November 7, 1404" instead of the correct date (Jan 24, 2026).
Solution
Added isTooOld() validation that rejects dates before 1970 (Unix epoch). When publishedDate fails validation, we now fall back to updatedDate before using the current time.
Steps to Reproduce