Skip to content

Fix/valgrind leaks #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabsow wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/valgrind leaks #76

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a640526
Fix cross-thread cluster message argv lifetime
gabsow Jan 18, 2026
b326cdc
Revert module GIL lock in innercomm handler
gabsow Jan 19, 2026
1dccca2
Fix leak on failed redisAsyncConnect
gabsow Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/cluster.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,9 @@ static void MR_ConnectToShard(Node* n){
return;
}
if (c->err) {
/* Let *c leak for now... */
/* Connection context was created but is in an error state - free it. */
RedisModule_Log(mr_staticCtx, "warning", "Error: %s\n", c->errstr);
redisAsyncFree(c);
return;
}
c->data = n;
Expand Down Expand Up @@ -1335,10 +1336,13 @@ int MR_ClusterInnerCommunicationMsg(RedisModuleCtx *ctx, RedisModuleString **arg
return RedisModule_WrongArity(ctx);
}

// we must copy argv because if the client will disconnect the redis will free it
/* We must copy argv because this command defers processing to the LibMR
* event-loop thread. Using RedisModule_HoldString() here is unsafe: strings
* originating from client command arguments may share the client's query
* buffer, which Redis can trim/realloc after the command returns. */
RedisModuleString **argvNew = MR_ALLOC(sizeof(RedisModuleString *) * argc);
for(size_t i = 0 ; i < argc ; ++i){
argvNew[i] = RedisModule_HoldString(NULL, argv[i]);
argvNew[i] = RedisModule_CreateStringFromString(NULL, argv[i]);
}

MessageCtx* msgCtx = MR_ALLOC(sizeof(*msgCtx));
Expand Down
Loading