Open
Conversation
Deep-copy argv in MR_ClusterInnerCommunicationMsg before handing to the event-loop thread, and lock the module GIL while parsing and dispatching the message to avoid use-after-free when Redis trims the client query buffer.
Keep argv deep-copy but drop ThreadSafeContextLock/Unlock wrapping in MR_ClusterInnerCommunicationMsgRun for testing whether deep-copy alone resolves the ASan UAF.
Free hiredis async context when redisAsyncConnect returns an error state, instead of leaking it (improves valgrind results under cluster send/reconnect scenarios).
gabsow
force-pushed
the
fix/valgrind-leaks
branch
from
7f82a6c to
1dccca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Addresses memory-safety issues in cluster communication.
redisAsyncFree(c)whenc->erris set to avoid leaking the async contextMR_ClusterInnerCommunicationMsg, switch fromRedisModule_HoldString()toRedisModule_CreateStringFromString()when copyingargvfor event-loop processing, preventing unsafe references to client query buffersWritten by Cursor Bugbot for commit 1dccca2. This will update automatically on new commits. Configure here.