EventedMapper as a proxy #74#3
Open
nawarian wants to merge 9 commits intoRespect:masterfrom
nawarian:master
Open
EventedMapper as a proxy #74#3nawarian wants to merge 9 commits intoRespect:masterfrom nawarian:master
nawarian wants to merge 9 commits intoRespect:masterfrom
nawarian:master
Conversation
Member
There was a problem hiding this comment.
Why this switch?
Can we use if instead?
if (!(is_callable($action)) || !($action instanceof Listener)) {
$message = 'Invalid type of action provided for event manager';
throw new \InvalidArgumentException($message, 400);
}
// The block below you can use for control or remove it
$events = $this->getEvents();
if (array_key_exists("attach", $events)) {
$this->dispatch("attach", array($eventName, $action));
}
$this->events[$eventName][] = $action;
Author
There was a problem hiding this comment.
Probably for future implementations or checks. I don't see any trouble by changing it.
@Rafael-BP could you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described under this issue under Respect\Relational there's an implementation of a Proxy interface to add events onto Respect\Data.
This could be user as this:
Same goes for every events: insert, update, delete. With suffixes: pre and post.
So there are six events to be listened: