Changes access modifier of MessageRelayFilter from "internal" to "public".#176
Open
DarkJune0122 wants to merge 2 commits intoRiptideNetworking:mainfrom
Open
Changes access modifier of MessageRelayFilter from "internal" to "public".#176DarkJune0122 wants to merge 2 commits intoRiptideNetworking:mainfrom
DarkJune0122 wants to merge 2 commits intoRiptideNetworking:mainfrom
Conversation
It's needed to fully suppot Server's OnMessageReceived method overwriting.
Author
|
Note: RiptideToolkit updates to support MessageIDs of uint instead of ushort, so in Toolkit's case specifically - we can't even use the relay. However, it's useful to make it public for others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short: It's needed to fully support Server's OnMessageReceived(...) method overriding.
Overriding OnMessageReceived(...) method is very useful, as it allows implementing custom handling methods.
RelayFilter has Enable/Disable methods public, but has "ShouldRelay" set to
internal, which makes RelayFilter useless for developers outside of raw Riptide usage, because while you can set filter values - you can't actually read them.As you can see from screenshot, RelayFilter.ShouldRelay is also the only method stopping us from allowing overriding:
Making this method public will make RelayFilter more useful.