Skip to content

fix: resolve flaky CLI tests and add GitHub Actions CI#297

Merged
RobinBlomberg merged 6 commits intoRobinBlomberg:masterfrom
elitan:fix/flaky-tests-and-ci
Feb 7, 2026
Merged

fix: resolve flaky CLI tests and add GitHub Actions CI#297
RobinBlomberg merged 6 commits intoRobinBlomberg:masterfrom
elitan:fix/flaky-tests-and-ci

Conversation

@elitan
Copy link
Contributor

@elitan elitan commented Oct 28, 2025

  • Fix flaky tests by ensuring all test tables exist regardless of execution order
    • Modified cli.test.ts to use shared migrate() from fixtures
    • Tests now create all required tables (foo_bar, enum, partitioned_table)
  • Add GitHub Actions workflow for CI testing
    • Runs tests on push to master and pull requests
    • Uses wait-on for intelligent database readiness detection
  • Remove obsolete version attribute from docker-compose.yml
  • Add wait-on package for database health checking
  • Add docker:wait npm script for local convenience

🤖 Generated with Claude Code

elitan and others added 5 commits October 28, 2025 21:02
- Fix flaky tests by ensuring all test tables exist regardless of execution order
  - Modified cli.test.ts to use shared migrate() from fixtures
  - Tests now create all required tables (foo_bar, enum, partitioned_table)
- Add GitHub Actions workflow for CI testing
  - Runs tests on push to master and pull requests
  - Uses wait-on for intelligent database readiness detection
- Remove obsolete version attribute from docker-compose.yml
- Add wait-on package for database health checking
- Add docker:wait npm script for local convenience

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use version from package.json packageManager field instead

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
GitHub Actions runners have docker compose (CLI plugin) not docker-compose (standalone tool)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
MySQL TCP port opens before DB is ready for connections. Add retry loop to wait for actual readiness.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@elitan elitan marked this pull request as draft October 28, 2025 20:10
- Add healthchecks to docker-compose.yml for MySQL and Postgres
- Use docker compose --wait flag to wait for services to be healthy
- Simplifies CI workflow and ensures databases are fully ready
- Updates docker:up script to include --wait flag

MySQL healthcheck includes start_period to allow proper initialization time.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@elitan elitan marked this pull request as ready for review October 28, 2025 20:13
@RobinBlomberg RobinBlomberg merged commit 396f28d into RobinBlomberg:master Feb 7, 2026
1 check passed
@RobinBlomberg
Copy link
Owner

Works great! Thank you! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants