Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

D* Lite Design Document Edit#627

Closed
ceelo777 wants to merge 6 commits intodesign/d_star_litefrom
master
Closed

D* Lite Design Document Edit#627
ceelo777 wants to merge 6 commits intodesign/d_star_litefrom
master

Conversation

@ceelo777
Copy link

@ceelo777 ceelo777 commented Jan 9, 2020

Description

Edited my design document for D* Lite.

Jiajun(Aaron) Mao and others added 6 commits November 24, 2019 17:42
* Adding design documents for cone of shame

* Update cone of shame design doc

* Update cone of shame design document

* update to include details regarding ROS service and costmap2d layer

* update ways of obtaining line cost2dmap layer and details of cone creation
* Merged waypoint_source and action_server into navigation_client
* Removed waypoint_source and action_server
* Created ray_Casting design document

* Fixed typos
* Created node for ground segmentation

* Added organization for following the algorithm

* Line fitting

* polished up some params

* parameter tuning

* refactor into pointcloud_filter node

* formatting

* where did that space come from

* oops found another

* removed unused include

* started addressing PR comments

* Addressed some comments, improved documentation

* addressed rest of comments and added documentation for least squares approach

* Some more small changes
* Added launch file for specifically setting the waypoint file path

* Fixed parseWaypointFile so whitespace and comments don't break it

* Split setting waypoint_file_path into two arguments: folder_path (default = sandbox/waypoints) and file_name

* Changed removeWhitespace into a one line call with str.erase and std::remove

* Made sandbox folder into a package

* Changed default folder_path to use igvc_sandbox package

* Changed default value of "reading_from_file" to "false"
* Created IOP research doc and updated READMEs.
* Removed a lot of comments
* Added back tldr
@oswinso
Copy link
Contributor

oswinso commented Jan 9, 2020

@ceelo777 I don't think this is what you want to do. This is a PR that wants to merge master into your branch, instead of the other way around. Since you already have #612 open, any new commits that you push onto your design/d_star_lite branch should automatically update the PR.

The only thing you need to do is to click the Re-request review button in the top right corner under reviewers, which will allow me to review your new changes.

@oswinso
Copy link
Contributor

oswinso commented Jan 9, 2020

As such, I'm closing this PR.

@oswinso oswinso closed this Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants