Merged
Conversation
sanatd33
requested review from
Squid5678 and
rishiso
and removed request for
Squid5678
automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
rishiso
requested changes
Nov 20, 2025
Contributor
rishiso
left a comment
rishiso
left a comment
There was a problem hiding this comment.
Overall looks good, a few comments
src/rj_strategy/include/rj_strategy/coordinator/waller_client.hpp
Outdated
Show resolved
Hide resolved
automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
rishiso
approved these changes
Nov 24, 2025
Contributor
rishiso
left a comment
rishiso
left a comment
There was a problem hiding this comment.
There are a few places we are still overflowing -1 but besides that LGTM
petergarud
reviewed
Dec 3, 2025
shourikb
requested changes
Dec 3, 2025
automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the waller from communication/Role Interface to a coordinator
The logic for wallers previously defined in
position/waller.cpphas not been changed.Overview:
Defense sends join group request through Client to Coordinator
Coordinator maintains ordered list of walling robots, sends updated copy to clients
Clients maintain their own copy of walling list
Defense asks Client for walling position, Client computes
Robot switches off from defense, sends leave group request