aalind told me to do this i ha5e this key board#2484
Merged
yuvrajdhadwal merged 1 commit intoRoboJackets:ros2from Feb 2, 2026
Merged
aalind told me to do this i ha5e this key board#2484yuvrajdhadwal merged 1 commit intoRoboJackets:ros2from
yuvrajdhadwal merged 1 commit intoRoboJackets:ros2from
Conversation
Squid5678
approved these changes
Feb 2, 2026
petergarud
approved these changes
Feb 2, 2026
| DEFINE_FLOAT64(params::kMotionControlParamModule, rotation_ki, 0.0, | ||
| "Ki for rotation ((rad/s)/(rad*s))"); | ||
| DEFINE_FLOAT64(params::kMotionControlParamModule, rotation_kd, 0.0, | ||
| DEFINE_FLOAT64(params::kMotionControlParamModule, rotation_kd, 0.9, |
Squid5678
pushed a commit
that referenced
this pull request
Feb 2, 2026
Co-authored-by: sanatd33 <saisanat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your pull request.
Associated / Resolved Issue
Resolves # or ClickUp card
Design Documents
Link
Steps to Test
Test Case 1
Expected result:???
Key Files to Review
Group 1
Group 2
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.