Issue #12: team-01 - Improving current fin flutter method

[aasitvora99]

Pull request type

Please check the type of change your PR introduces:

• Code base additions (bugfix, features)
• Code maintenance (refactoring, formatting, renaming, tests)
• ReadMe, Docs and GitHub maintenance
• Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

• ReadMe, Docs and GitHub maintenance:

  • Spelling has been verified
  • Code docs are working correctly

• Code base maintenance (refactoring, formatting, renaming):

  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

• Code base additions (for bug fixes / features):

  • Tests for the changes have been added
  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...

What is the new behavior?

Enter text here...

Does this introduce a breaking change?

• Yes
• No

Other information

Enter text here...

[Gui-FernandesBR]

Hey @aasitvora99 !

I swear this was not a trick challenge. But it turns out there was a misunderstanding during the approach for solving this one.

First let's take a look at the equation for fin flutter velocity, which can be taken from here:

The term "P", which stands for air pressure, is meant to be the air pressure used during the flight simulation. In other words, once we already have a environment object being used by the flight class, we can take the same pressure profile from environment object and use it to evaluate the fin flutter velocity at each altitude that the rocket will experienced. By doing this, we guarantee that the final implementation accomplish with every single type of pressure profile selected by the user (e.g. based on GFS, Ensenbles, Reanalysis, etc.). And that's exactly what RocketPy is currently doing, as you can see through these code lines:

And in the end, what you have done during the hackathon is to calculate the fin flutter velocity considering a single pressure model, which was the standard atmosphere model, also based on the same reference I pointed earlier in this comment.

Unfortunately I am afraid we can not give any points on this implementation.
However, I'd like to thank you for trying to add enhancements on this kind of function. And I see that there's a lack of documentation on this fin flutter function, this could help others in the future. I will try to addres that one.

And of course I'm open to discuss anything that you want to clarify, thank you!