Skip to content

refactor: simplify README generation flow#104

Open
artengin wants to merge 9 commits intomainfrom
refactor-init-readme-generator-6
Open

refactor: simplify README generation flow#104
artengin wants to merge 9 commits intomainfrom
refactor-init-readme-generator-6

Conversation

@artengin
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21879018875

Details

  • 44 of 44 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 98.99%

Totals Coverage Status
Change from base Build 21847282252: -0.09%
Covered Lines: 392
Relevant Lines: 396

💛 - Coveralls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors parts of the README generation flow used by the init command, updating templates and tests accordingly.

Changes:

  • Simplifies InitCommand README generation control flow (save based on generator presence) and tweaks the setAppInfo() call.
  • Updates ReadmeGenerator block mapping (Clerk) and removes DataDog/ArgoCD from configurable resources.
  • Adjusts README templates and InitCommandTest fixtures/expectations to match the updated resource list.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Commands/InitCommand.php Adjusts README generation flow and updates the setAppInfo() invocation.
src/Generators/ReadmeGenerator.php Renames Clerk block handler mapping and removes DataDog/ArgoCD from configurable resources.
resources/md/readme/RESOURCES.md Removes DataDog/ArgoCD placeholder/tag sections from the README resources template.
tests/InitCommandTest.php Removes expectations for DataDog/ArgoCD prompts/outputs during init runs.
tests/fixtures/InitCommandTest/full_readme.md Updates expected generated README content by removing DataDog/ArgoCD entries.
tests/fixtures/InitCommandTest/default_readme.md Updates expected generated README content by removing DataDog/ArgoCD entries.
tests/fixtures/InitCommandTest/default_readme_with_mobile_app.md Updates expected generated README content by removing DataDog/ArgoCD entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@artengin
Copy link
Contributor Author

artengin commented Feb 3, 2026

Tested on the project, everything works as expected.

@artengin artengin assigned DenTray and unassigned artengin Feb 3, 2026
@DenTray DenTray assigned artengin and unassigned DenTray Feb 10, 2026
@artengin artengin assigned DenTray and unassigned artengin Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants