cipher: refactor asynchronous stream cipher traits #2083
Closed
+58
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing in favor of #2280. |
newpavlov
added a commit
that referenced
this pull request
Feb 4, 2026
This trait is used only by the CFB mode. It either should be reworked (see #2083) or replaced with inherent methods in the `cfb-mode` crate. To not block the v0.5 release, it's worth to simply remove it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
AsyncStreamCiphertrait into separateasync_streammodule and splits into separate encryptor and decryptor traits, making them sub-traits of the counterpart block mode traits.TODO: add buffering wrapper and traits for buffered async stream ciphers or do it with inherent methods