Skip to content

digest: replace subtle with ctutils #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 2 commits into from
Feb 12, 2026
+7 −5
Merged

digest: replace subtle with ctutils #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac415f4
digest: replace `subtle` with `ctutils`
tarcieri Feb 12, 2026
8e8e936
use nightly-2026-02-11 for miri
tarcieri Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/elliptic-curve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ jobs:
MIRIFLAGS: "-Zmiri-symbolic-alignment-check -Zmiri-strict-provenance"
steps:
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@nightly
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: nightly-2026-02-11 # pinned due to rust-lang/miri#4855
- run: rustup component add miri && cargo miri setup
- run: cargo miri test --all-features
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions digest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ common = { version = "0.2", package = "crypto-common" }

# optional dependencies
block-buffer = { version = "0.11", optional = true }
subtle = { version = "2.4", default-features = false, optional = true }
blobby = { version = "0.4", optional = true }
const-oid = { version = "0.10", optional = true }
ctutils = { version = "0.4", optional = true }
zeroize = { version = "1.7", optional = true, default-features = false }

[dev-dependencies]
Expand All @@ -28,7 +28,7 @@ sha2 = "0.11.0-rc.5"
[features]
default = ["block-api"]
block-api = ["block-buffer"] # Enable block API traits
mac = ["subtle"] # Enable MAC traits
mac = ["dep:ctutils"] # Enable MAC traits
rand_core = ["common/rand_core"] # Enable random key generation methods
getrandom = ["common/getrandom", "rand_core"]
oid = ["const-oid"]
Comment on lines 30 to 34
Copy link
Member Author

@tarcieri tarcieri Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar: seems like we should use dep:block-buffer and dep:const-oid. I'll open a followup PR.

Expand Down
2 changes: 1 addition & 1 deletion digest/src/mac.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use common::{Output, OutputSizeUser, Reset};

use common::typenum::Unsigned;
use core::fmt;
use subtle::ConstantTimeEq;
use ctutils::CtEq;

/// Marker trait for Message Authentication algorithms.
pub trait MacMarker {}
Expand Down