Skip to content

Add cpuinfo_max_freq constants and update methods#156

Open
ZUANVFX01 wants to merge 1 commit intoRve27:mainfrom
ZUANVFX01:patch-4
Open

Add cpuinfo_max_freq constants and update methods#156
ZUANVFX01 wants to merge 1 commit intoRve27:mainfrom
ZUANVFX01:patch-4

Conversation

@ZUANVFX01
Copy link
Contributor

Added cpuinfo_max_freq constants for CPUs and updated methods to accept optional cpuInfoMaxPath.

Added cpuinfo_max_freq constants for CPUs and updated methods to accept optional cpuInfoMaxPath.
@Rve27
Copy link
Owner

Rve27 commented Feb 3, 2026

Explain what this is for? To get the CPU max freq, it is already through the scaling_max_freq node. i think it is not necessary to fallback to cpuinfo_max_freq, because all devices that use snapdragon must have a scaling_max_freq node.

also can you remove AI things like comment in every code section, because it makes the code unclean, please read CONTRIBUTING.md

@ZUANVFX01
Copy link
Contributor Author

ZUANVFX01 commented Feb 4, 2026

sorry in advance, btw on my device Android 16 rom hos 3, no highest frequency number appears you can see this screenshot.
Picsart_26-02-04_08-37-24-202
I would like to tidy up the code if you are done let me include this otherwise I wrote it in vain. I don't know, sometimes the highest number appears, sometimes it doesn't appear, maybe it's caused by kernel limits if the temperature heats up

By the way, your argument is correct, but whether this is just a combination of additional additions or not is up to yo

@Rve27
Copy link
Owner

Rve27 commented Feb 4, 2026

cleanup your code first and then merge the other your PR to here, because it is related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants