Skip to content

Conversation

@stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented Nov 24, 2025

Currently deployed at https://omopcat.safehr-data.org/ because we haven't publicly released

Had to move around the datatable call earlier to be able to get numeric formating working correctly

@stefpiatek stefpiatek requested a review from milanmlft November 24, 2025 10:18
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (77b60c7) to head (21d1f86).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   93.46%   93.65%   +0.18%     
==========================================
  Files          23       23              
  Lines         781      804      +23     
==========================================
+ Hits          730      753      +23     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update tests and add a missing import to get the checks to pass, but other than that looking ✨

@stefpiatek
Copy link
Contributor Author

Interestingly, test of selecting reactive value rows is failing. Wonder if it doesn't like storing the data table as a reactive value. May see if there's a way to generate the data table manually from a the reactive value but at first attempt it didn't work

@stefpiatek stefpiatek merged commit b47b822 into main Nov 25, 2025
10 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/ui_tweaks branch November 25, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants