-
Notifications
You must be signed in to change notification settings - Fork 0
Update UI from initial feedback #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moved omopcat version to footer in production
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 93.46% 93.65% +0.18%
==========================================
Files 23 23
Lines 781 804 +23
==========================================
+ Hits 730 753 +23
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
milanmlft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update tests and add a missing import to get the checks to pass, but other than that looking ✨
|
Interestingly, test of selecting reactive value rows is failing. Wonder if it doesn't like storing the data table as a reactive value. May see if there's a way to generate the data table manually from a the reactive value but at first attempt it didn't work |
Currently deployed at https://omopcat.safehr-data.org/ because we haven't publicly released
Had to move around the datatable call earlier to be able to get numeric formating working correctly