Replace Subject with login_hint#774
Open
blombard wants to merge 1 commit intoSAML-Toolkits:masterfrom
Open
Conversation
'Subject' is not supported and must not be set. A subject can instead be provided by adding a login_hint parameter to the HTTP request to the single sign-on URL
Collaborator
|
@blombard can you provide a PR where we add to the documentation the use of the login_hint trick rather than remove the use of Subject. The fact that Google/MSFT accept this parameter does not mean that others accept it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We should not use
Subjectanymore but uselogin_hintinstead.Perhaps we could also remove all code related to
name_identifier_value_requestedin this PR or a follow-up one? (Or maybe not if some IdPs are still using it?)Microsoft doc
https://learn.microsoft.com/en-us/entra/identity-platform/single-sign-on-saml-protocol#subject
Google doc
https://support.google.com/a/answer/15544042?hl=en#
Error