feat: update system trust to support scope #5639
Open
+131
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilie-Jacquier
requested review from
CCFenner,
manjunathSurendrakumar and
phgermanov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Trust team introduced a second parameter, scope, to retrieve the system token. They also changed the request from a GET with query parameters to a POST request when the system and scope must be defined.
This PR addresses these changes so that systems already using system trust can continue to use the default scope and specify the system only. However, if a Piper step (such as secret scanning) needs a different scope, the default value must be changed from just the system name to the following format:
system-name<scope>scope-nameChecklist