Allow query to be applied to an ast with Tree.fromTree#45
Open
BebeSparkelSparkel wants to merge 5 commits intoSBoudrias:masterfrom
BebeSparkelSparkel:master
Open
Allow query to be applied to an ast with Tree.fromTree#45BebeSparkelSparkel wants to merge 5 commits intoSBoudrias:masterfrom BebeSparkelSparkel:master
BebeSparkelSparkel wants to merge 5 commits intoSBoudrias:masterfrom
BebeSparkelSparkel:master
Conversation
Owner
|
Hey, could you try to reduce the whitespace and other unrelated changes? It's easier for maintainers if you can send PR focusing on a single change. |
Author
|
@SBoudrias I have reduced the whitespace changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed the Tree obj
Added
Tree.fromTreeandTree.fromSourceconstructorsAllows a Tree to be created from an existing ast instead of only from a source string
Breaks backwards compatibility, so could you please let me know how you would like to integrate this?
Also there aren't as many changes as it seems in the diff. I had to indent the test code to cover two cases.