Skip to content

Deprecate Python 3.7 & 3.8 support#4826

Open
Repiteo wants to merge 1 commit intoSCons:masterfrom
Repiteo:deprecate-python
Open

Deprecate Python 3.7 & 3.8 support#4826
Repiteo wants to merge 1 commit intoSCons:masterfrom
Repiteo:deprecate-python

Conversation

@Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Feb 3, 2026

Originally part of #4825, this PR simply deprecates Python 3.7 & 3.8. The only other change is removing a check in ActionTests.py, as I realized that was conditional on 3.6 specifically, so it being bumped to 3.7 was a mistake

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@Repiteo Repiteo mentioned this pull request Feb 3, 2026
3 tasks
@mwichmann
Copy link
Collaborator

The deprecated 3.7 failed a test (SCONSFLAGS.py(. Side effect of us being so fussy about exact outputs - the (expected) presence of a deprecation message shouldn't blow it up...

@bdbaddog
Copy link
Contributor

bdbaddog commented Feb 4, 2026

The deprecated 3.7 failed a test (SCONSFLAGS.py(. Side effect of us being so fussy about exact outputs - the (expected) presence of a deprecation message shouldn't blow it up...

Didn't we handle this in the testing framework? (or is my memory failing me on this one?)

@mwichmann
Copy link
Collaborator

There's something for the deprecation itself. There's not for an individual test that gets extra output due to using a deprecated Python version. I'm kind of surprised it hit only one test. We should be able to come up with something - it might possibly be related to the change to runtest to add logging.

@bdbaddog
Copy link
Contributor

bdbaddog commented Feb 6, 2026

There's something for the deprecation itself. There's not for an individual test that gets extra output due to using a deprecated Python version. I'm kind of surprised it hit only one test. We should be able to come up with something - it might possibly be related to the change to runtest to add logging.

Looks like the failing part is some additional checks @mwichmann added in 2024, and we've not had any deprecations since then so it didn't get hit til now..
Taking a look at a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants