Open
Conversation
…der has already been parsed.
…is done at the level of NIAK_READ_MINC and NIAK_READ_NIFTI). Code is cleaner that way.
Merged master into an old PR.
Bug fix, introduced by a recent merge.
Contributor
|
@pbellec What is the statue of this old pull request? Should I work on it to have it merge, or we just close it. Its old and full of conflicts. |
Member
Author
|
I have automatically resolved conflicts ("theirs") and, after review, I think all the changes I made are in there. It's not a critical PR, but it adds a nice feature and cleans up a bit the code of the reader/writer, so I'd like to push it through. I don't think it should break our tests ... fingers crossed. |
Member
Author
|
very weird... the scores tests fail ?!? will have a look :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #169 Although the added feature is minor, I have refactored a bit the reader/writer. There is now a separate function
niak_read_data_mincto read the data array in a minc file, provided a header structure is available. Also the un(g)zipping of file is now handled by a generic functionniak_unzip. The feature is available for both minc and nifti (niak_read_data_niftiandniak_read_data_minc), and the other functions (niak_read_minc,niak_read_nifti,niak_read_vol) now depend on these functions.