Feat/molecule autosuggest dropdownlist a11y#2955
Merged
Conversation
andresin87
reviewed
Nov 17, 2025
| } | ||
| ) | ||
|
|
||
| const accessibilityProps = { |
Member
There was a problem hiding this comment.
set it into the object directly (if it is used only once) or define it outside of the component fn cycle
Contributor
Author
There was a problem hiding this comment.
The problem is that the object that’s already created is related to the autosuggest (autosuggestSelectionProps), but not to the wrapper div. Defining it outside the component isn’t possible either, since I’m using a prop value.
Sabri1209
requested review from
andresz1,
kikoruiz and
sui-bot
as code owners
|
andresin87
reviewed
Nov 19, 2025
| expect(container.innerHTML).to.not.have.lengthOf(0) | ||
| }) | ||
|
|
||
| it('should NOT extend classNames', () => { |
Member
There was a problem hiding this comment.
Do not remove it. just change it to 'should extend classNames'
andresin87
reviewed
Nov 19, 2025
Comment on lines
73
to
83
| it('should NOT extend classNames', () => { | ||
| // Given | ||
| const props = {className: 'extended-classNames'} | ||
| const findSentence = str => string => string.match(new RegExp(`S*${str}S*`)) | ||
|
|
||
| // When | ||
| const {container} = setup(props) | ||
| const findClassName = findSentence(props.className) | ||
|
|
||
| // Then | ||
| expect(findClassName(container.innerHTML)).to.be.null |
Member
There was a problem hiding this comment.
const props = {className: 'extended-classNames'}
const findSentence = str => string => string.match(new RegExp(`S*${str}S*`))
// When
const {container} = setup(props)
const findClassName = findSentence(props.className)
// Then
expect(findClassName(container.innerHTML)).to.not.be.null
|
|
andresin87
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Molecule/autossugest
Molecule/dropdownist
Description, Motivation and Context
Apply some a11y requirements
Types of changes